themabus wrote:'results in wrong gaps'
and how exactly would you tell right from wrong, F1ReB4LL?
by rereading subcode N times until your expected result (common value for given system)
is returned, like you suggest in post above?
creativity isn't something you're lacking, F1ReB4LL
i must applaud for that
themabus wrote:I've already explained you about EAN, there's nothing about 'fixing' anything.
are you sure it isn't 'fixing' F1ReB4LL?
because some combination of Drive X and Software Y return those results after N tries?
could you suggest a better fitting word then, please?
themabus wrote:is this not enough to base correction upon?
when you're correcting EAN, F1ReB4LL, you have far less evidence of mastering problems
You know, what your problem is? You don't want to read my explanations, you just ignore everything and repeat the same things every time, like a parrot.
When EAC meets the EAN sector between 2 tracks, it assumes this sector belongs to the next track, while in reality it belongs to the previous one.
EAN sector usually replaces one of the real sectors. Sometimes, it may replace the very last sector of the track or the very first one:
01 09 01 02 20 10 00 15 57 12 49 CC
01 09 01 02 20 11 00 15 57 13 F3 BC
02 00 00 00 00 00 00 00 00 14 73 C0
01 10 00 00 01 73 00 15 57 15 08 9F
01 10 00 00 01 72 00 15 57 16 92 AD
When EAC faces this situation, it always assumes this EAN sector belongs to the next track (Track#10 here), while it can belong to the previous track (#09), too (this is described in the IEC 60908). It's one of the EAC bugs and it's not drive-dependant, it works like this even with virtual drives, so it's about decoding the subs manually, not 'looking for the correct drive' and not about 'fixing the gaps'. I hope you won't touch this thing anymore.
themabus wrote:are you not correcting offset?
you are.
basing your actions on assumption that you know correct value
and data returned from CD as it is needs this correction
are you correcting gaps?
you are.
the same way
We don't correct any gaps, stop imagine things. We can only refuse results from one of the tools, when it's known it has a bug. But we never fix any gaps, just because we don't like them and all the other CDs on this system have different beautiful rounded gaps.
As for the offset, I repeat, you can't dump the CD without fixing it, because the post-data audiotrack will have the garbage, you can either fix the offset or cut the pregap out to mask it (like CDRWin does). So it's not about assuming the values, it's just about dumping the _proper_ range.
themabus wrote:if you think inclusion of Lead-In/ Lead-Out,
protected areas such as Sega/DC rings and what not for each CD would be a nice,
please think some more about it F1ReB4LL
I'm afraid it's very hard to find a drive, which can read ALL the sectors. Even your beloved Plextors fail at reading some of the -150 to -1 sectors (but they do read pre -150 sectors with the LeadIn area). And in my opinion it would be better to dump everything in scrambled form, like it's written on the real CDs. Descrambled datatracks remind me those decrypted NeoGeo roms, which don't really contain the actual media content.
themabus wrote:strangely enough you forgot to mention another important aspect of offset correction
most important perhaps
are those few bytes we'd recover really that meaningful? - it's only a fraction of second
(less than 1/75 most of the time)
and after all we're not including a lot more bytes from other areas, like you mention above
so, maybe what really matters about offset correction
is the fact that it eliminates meaningless clones
and makes comparation of data far more convenient in following cases:
* same CDs from different masters
(there are such cases in db when one record has several offsets)
* different editions for same game
* different regions for same game
* maybe even different systems for same game
I repeat, the most important thing is to read the whole 'Data' range from the first byte upto the last, without any cuts, TOSEC fails at that point. Eliminating the clones is a nice bonus, but it's not about targeting at eliminating them. OK, a few examples:
1) http://redump.org/disc/2597/ -- by your logic we should round all the 00:01:74 gaps here to 00:02:00.
2) http://redump.org/disc/5194/ -- by your logic we should round all the 00:02:02 gaps here to 00:02:00
3) http://redump.org/disc/5263/ and http://redump.org/disc/3661/ -- same CD, but the offset is 0, audiotracks are the same, but shifted, by your logic we should find the offset _somehow_ and merge the entries.
4) http://redump.org/disc/3717/ -- this CD contains a standard 10-secs warning, but in this particular case it was shifted during the mastering and misses some samples at the end. By your logic we should replace it with the known 10-secs warning instead of the one written on the real CD, because it was corrupted during the mastering.
5) http://redump.org/disc/3376/ and http://redump.org/disc/5266/ -- audiotracks have a 1-sectors length difference, we should also fix it, right?
etc, etc, etc. I'm afraid this won't be about the proper dumping anymore, just about the assuming (actually, assing everyone).
themabus wrote:for reference check psxt001z --fix option
or guides describing extraction of data from protected media,
where you'd replace sector content with generic $55 pattern
with offset correction and certain interpretations of subcode you are familiar already)
in this case, with this correction applied, no information is lost
would tracks from both sets be recombined into one stream again, they'd match
Fixing the very last pre-audio Mode2 track is necessary, it's not about mastering issues, it's about most of the drives read this sector incorrectly (and differently every time). Some of the drives do read this sector properly, though, there's no need in psxt001z --fix for them. So you've chosen the wrong example again.
As for the replacing sectors with $55 pattern - guess, this is about PC discs, dunno, I don't like the PC section at all, it's a pile of trash in its current state.
Jackal wrote:I think themabus is winning this argument.. we're not preserving subchannels and as a result a lot of dump info and data has been lost already while preserving.. we're adding the effect of these subchannel 'errors' into the main channel data, but there's no real point in doing that.. it doesn't improve the dump.. the only way to properly deal with it and really get 100% dumps is to merge all tracks (after all, we're not sure which gaps are intended, even if we have the subchannels) and accurately preserve the subchannels, which we're not doing..
Yes, we should think about adding the subchannels. But it's not possible with the current db, you can't assign more than one subs dump to a single entry now (while the same title usually has different subs on different pressings).
Jackal wrote:We're already adjusting the dump data to remove offset mastering effects, so why shouldn't we do the same for gaps and only record any subchannel discrepancies instead of applying them to the dump data?
People, what 'offset mastering effects' are you talking about?
I've thought, at least our mods do understand the main concept, look like I was wrong.
gigadeath wrote:We round things up because THE SOFTWARES THEMSELVES ROUND THE THINGS UP, wheter they like/dislike the drives, whether they like/dislike the subs, wheter they like/dislike that particular disc.
The main problem is that there's currently no proper subchannels-dumping tool, able to verify each sector and reread it, if its AMSF is incorrect or Q-CRC doesn't match (I'm not talking about subchannels-based protections now).