Redump Forum — [Resolved] Error count question

Re: [Resolved] Error count question

null@example.com (F1ReB4LL) — Mon, 12 Sep 2016 04:18:12 +0000

iR0b0t wrote:

Where moddified subheaders and ECC/EDC mismatch is not an actual ERROR and should not be included into final errors count.

Disagree. IMO, we should include any imperfections into the total errors count. Otherwise, there should be a "Warnings" count field as well.
I'm not talking about NoEDC sectors in NoEDC images, of course, I don't understand the reason to warn there.

Re: [Resolved] Error count question

null@example.com (iR0b0t) — Sat, 10 Sep 2016 19:01:45 +0000

edcchhk returns a correct amount of ERRORS, just look for that line and not for total.

CDmage (at least the last version i was ever using) returns any "errors" you can ever have: moddified subheaders, ECC/EDC error etc. Where moddified subheaders and ECC/EDC mismatch is not an actual ERROR and should not be included into final errors count.

case1 = 1
case2 = 0

Re: [Resolved] Error count question

null@example.com (F1ReB4LL) — Sat, 10 Sep 2016 14:58:43 +0000

Jackal wrote:

They do show as errors in CDMage?

He says "no" (3rd post).

"while user data does match the expected ECC/EDC there is no EDC" -- IMO, it says "there's no ECC/EDC error, but EDC itself is null" and nothing about subheaders at all, that's normal for NoEDC images.

Re: [Resolved] Error count question

null@example.com (Jackal) — Sat, 10 Sep 2016 14:44:31 +0000

F1ReB4LL wrote:

I think it's better to report the number of errors from CDMage, because edcchhk treats many cases as "warnings", that's confusing.

I agree.. but I think the 1337 and 46113 are the sectors with modified subheaders. They do show as errors in CDMage?

Re: [Resolved] Error count question

null@example.com (F1ReB4LL) — Sat, 10 Sep 2016 13:59:48 +0000

"Number of sector(s) where while user data does match the expected ECC/EDC there is no EDC" -- most likely these numbers just show the number of Mode 2 Form 1 sectors in the NoEDC image, these are not errors.

I think it's better to report the number of errors from CDMage, because edcchhk treats many cases as "warnings", that's confusing.

Re: [Resolved] Error count question

null@example.com (fuzzball) — Sat, 10 Sep 2016 13:55:13 +0000

reentrant wrote:

Are the sectors readable in simple imaging tools like IsoBuster?

Yes. Both are PlayStation disc.

case 1:
http://redump.org/disc/29762/

case 2:
http://redump.org/disc/15196/
http://redump.org/disc/15257/

Re: [Resolved] Error count question

null@example.com (reentrant) — Sat, 10 Sep 2016 13:44:21 +0000

What's the value of EDC for such sectors: 0 or different than 0? Maybe value of 0 is a special case...
Are the sectors readable in simple imaging tools like IsoBuster?

Re: [Resolved] Error count question

null@example.com (fuzzball) — Sat, 10 Sep 2016 13:25:22 +0000

reentrant wrote:

What does CDmage report?

1 and 0.

Re: [Resolved] Error count question

null@example.com (reentrant) — Sat, 10 Sep 2016 12:33:45 +0000

From code:

                    //
                    // Might be Mode 2, Form 2
                    //
                    if (
                        edc_compute(0, sector + 0x10, 0x91C) == get32lsb(sector + 0x10 + 0x91C)
                        ) {
                        return 3; // Mode 2, Form 2
                    }
                    else {
                        return 4; // Mode 2, No EDC (for PlayStation)
                    }

What you're asking is if return 4 is in error path. Yes. EDC doesn't match for the sector. What does CDmage report?
So I think it's 1338 and 46113.

[Resolved] Error count question

null@example.com (fuzzball) — Sat, 10 Sep 2016 12:16:32 +0000

case 1:

Number of sector(s) where user data doesn't match the expected ECC/EDC: 1
Number of sector(s) where while user data does match the expected ECC/EDC there is no EDC: 1337

Error count is 1? or 1337? or 1+1337=1338?

case 2:

Number of sector(s) where while user data does match the expected ECC/EDC there is no EDC: 46113

Error count is 0? or 46113?